crypto-org-chain / chain-main

Cronos POS Chainโ›“: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
497 stars 352 forks source link

Problem: expedited related gov params are not adjusted #1087

Closed mmsqe closed 4 weeks ago

mmsqe commented 4 weeks ago

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.

Project coverage is 36.61%. Comparing base (452e088) to head (2affcee). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
app/upgrades.go 72.22% 6 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1087 +/- ## ========================================== + Coverage 36.52% 36.61% +0.08% ========================================== Files 101 101 Lines 14360 14396 +36 ========================================== + Hits 5245 5271 +26 - Misses 8168 8174 +6 - Partials 947 951 +4 ``` | [Flag](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage ฮ” | | |---|---|---| | [integration_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `25.70% <0.00%> (-0.07%)` | :arrow_down: | | [integration_tests_byzantine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.24% <0.00%> (-0.03%)` | :arrow_down: | | [integration_tests_gov](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.51% <0.00%> (-0.03%)` | :arrow_down: | | [integration_tests_grpc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.51% <0.00%> (-0.03%)` | :arrow_down: | | [integration_tests_ibc](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `27.43% <0.00%> (-0.07%)` | :arrow_down: | | [integration_tests_ledger](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.49% <0.00%> (-0.03%)` | :arrow_down: | | [integration_tests_slow](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.49% <0.00%> (-0.03%)` | :arrow_down: | | [integration_tests_solomachine](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `11.28% <0.00%> (-0.03%)` | :arrow_down: | | [integration_tests_upgrade](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `?` | | | [unit_tests](https://app.codecov.io/gh/crypto-org-chain/chain-main/pull/1087/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | `12.01% <72.22%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.