crypto-org-chain / chain-main

Cronos POS Chainโ›“: Croeseid Testnet and beyond development
https://cronos-pos.org/
Other
497 stars 352 forks source link

Problem: memiavl setup code is not clean #994

Closed yihuang closed 1 year ago

yihuang commented 1 year ago

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov[bot] commented 1 year ago

Codecov Report

Merging #994 (7748e31) into master (836309b) will decrease coverage by 0.11%. The diff coverage is 100.00%.

:exclamation: Current head 7748e31 differs from pull request most recent head 3484cfc. Consider uploading reports for the commit 3484cfc to get more accurate results

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   33.16%   33.06%   -0.11%     
==========================================
  Files         128      126       -2     
  Lines       20029    19999      -30     
==========================================
- Hits         6642     6612      -30     
  Misses      12329    12329              
  Partials     1058     1058              
Flag Coverage ฮ”
integration_tests 20.68% <100.00%> (-0.10%) :arrow_down:
integration_tests_byzantine 9.62% <100.00%> (-0.06%) :arrow_down:
integration_tests_gov 9.95% <100.00%> (-0.14%) :arrow_down:
integration_tests_grpc 9.93% <100.00%> (-0.14%) :arrow_down:
integration_tests_ibc 24.76% <100.00%> (-0.01%) :arrow_down:
integration_tests_ledger 9.82% <100.00%> (-0.04%) :arrow_down:
integration_tests_slow 9.82% <100.00%> (-0.04%) :arrow_down:
integration_tests_solomachine 9.62% <100.00%> (-0.04%) :arrow_down:
integration_tests_upgrade 9.93% <100.00%> (-0.14%) :arrow_down:
unit_tests 10.97% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage ฮ”
app/app.go 91.78% <100.00%> (รธ)
cmd/chain-maind/app/app.go 83.52% <100.00%> (รธ)