Problem: halt-height is not deterministic

[yihuang]

Solution:

• port the fix from sdk: https://github.com/cosmos/cosmos-sdk/pull/16639

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• [ ] Have you read the CONTRIBUTING.md?
• [ ] Does your PR follow the C4 patch requirements?
• [ ] Have you rebased your work on top of the latest master?
• [ ] Have you checked your code compiles? (make)
• [ ] Have you included tests for any non-trivial functionality?
• [ ] Have you checked your code passes the unit tests? (make test)
• [ ] Have you checked your code formatting is correct? (go fmt)
• [ ] Have you checked your basic code style is fine? (golangci-lint run)
• [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• [ ] If your changes affect the client infrastructure, have you run the integration test?
• [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

[codecov[bot]]

Codecov Report

Merging #998 (a6c8c6c) into master (681c32b) will decrease coverage by 9.04%. The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   33.07%   24.03%   -9.04%     
==========================================
  Files         126      126              
  Lines       19999    20013      +14     
==========================================
- Hits         6615     4811    -1804     
- Misses      12327    14545    +2218     
+ Partials     1057      657     -400     

Flag	Coverage Δ
integration_tests	20.68% <38.88%> (-0.01%)	:arrow_down:
integration_tests_byzantine	9.63% <27.77%> (+0.01%)	:arrow_up:
integration_tests_gov	9.97% <27.77%> (+0.01%)	:arrow_up:
integration_tests_grpc	9.95% <27.77%> (+0.01%)	:arrow_up:
integration_tests_ibc	?
integration_tests_ledger	9.84% <27.77%> (+0.01%)	:arrow_up:
integration_tests_slow	9.84% <27.77%> (+0.01%)	:arrow_up:
integration_tests_solomachine	9.63% <27.77%> (+0.01%)	:arrow_up:
integration_tests_upgrade	?
unit_tests	10.99% <27.77%> (+0.02%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app/app.go	90.21% <38.88%> (-2.13%)	:arrow_down:

... and 37 files with indirect coverage changes