yihuang commented 4 months ago

Solution:

keep it api compatible with both

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

[ ] Have you read the CONTRIBUTING.md?
[ ] Does your PR follow the C4 patch requirements?
[ ] Have you rebased your work on top of the latest master?
[ ] Have you checked your code compiles? (make)
[ ] Have you included tests for any non-trivial functionality?
[ ] Have you checked your code passes the unit tests? (make test)
[ ] Have you checked your code formatting is correct? (go fmt)
[ ] Have you checked your basic code style is fine? (golangci-lint run)
[ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
[ ] If your changes affect the client infrastructure, have you run the integration test?
[ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
[ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
[ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

New Features
- Introduced object storage functionality in the versiondb package, allowing users to access object-oriented storage capabilities.
- Added a new method CacheWrapWithTrace for enhanced tracing of cache operations in versiondb.
Changes
- Removed support for other streaming services in the version database, aligning with a focus on compatibility with the upstream SDK.
- Modified build configurations to incorporate object storage functionality, including updates to the BUILD_TAGS for improved linting processes.
Bug Fixes
- Updated dependency versions for improved stability and compatibility.

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent updates enhance compatibility with the upstream SDK while introducing new object storage capabilities. Key changes include the discontinuation of support for external streaming services, updates to build configurations, and the addition of object management methods in the versiondb and rootmulti packages. These modifications streamline the codebase, improve maintainability, and position the project for future enhancements.

Changes

File	Change Summary
`CHANGELOG.md`	Documents strategic shift towards upstream SDK compatibility and discontinuation of other services.
`Makefile`, `.github/workflows/lint.yml`	Updated build tags to include `objstore`, enhancing the build configuration.
`go.mod`, `gomod2nix.toml`, `store/go.mod`, `versiondb/go.mod`	Updated versions of `cosmossdk.io/store` and other dependencies to more recent commits.
`store/cachemulti/store.go`	Modified `NewStore` parameter, changing the first argument to `nil`.
`store/rootmulti/objstore.go`	New file implementing object storage functionality with methods for `ObjKVStore`.
`store/rootmulti/store.go`	Removed `GetObjKVStore` method, streamlined object type handling in `loadCommitStoreFromParams`.
`versiondb/multistore.go`	Updated type assertion and modified cache initialization; removed `GetObjKVStore`.
`versiondb/objstore.go`	Added `GetObjKVStore` method to `MultiStore` for accessing object stores.
`store/rootmulti/store.go`	Introduced `CacheWrapWithTrace` method, currently not implemented.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant MultiStore
    participant Cache
    participant ObjectStore

    App->>MultiStore: Request ObjKVStore
    MultiStore->>Cache: Load Cache Store
    Cache->>ObjectStore: Retrieve Object Store
    ObjectStore-->>MultiStore: Return Object Store
    MultiStore-->>App: Respond with ObjKVStore

Poem

🐇 In the meadow where code does play,
A rabbit hops with cheer today!
Changes made, with care and thought,
New features bloom, old ties are caught.
With objstores here and streams away,
Let’s hop along, it’s a bright new day! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (7f581a6) to head (0fc0435).

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1518/graphs/tree.svg?width=650&height=150&src=pr&token=92w0Dz1Coj&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1518 +/- ## ========================================== + Coverage 35.87% 36.84% +0.96% ========================================== Files 136 117 -19 Lines 9809 8124 -1685 ========================================== - Hits 3519 2993 -526 + Misses 5894 4766 -1128 + Partials 396 365 -31 ``` | [Files](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1518?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [store/cachemulti/store.go](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1518?src=pr&el=tree&filepath=store%2Fcachemulti%2Fstore.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#diff-c3RvcmUvY2FjaGVtdWx0aS9zdG9yZS5nbw==) | `0.00% <0.00%> (ø)` | | | [store/rootmulti/store.go](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1518?src=pr&el=tree&filepath=store%2Frootmulti%2Fstore.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#diff-c3RvcmUvcm9vdG11bHRpL3N0b3JlLmdv) | `4.34% <0.00%> (+0.11%)` | :arrow_up: | | [store/rootmulti/objstore.go](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1518?src=pr&el=tree&filepath=store%2Frootmulti%2Fobjstore.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#diff-c3RvcmUvcm9vdG11bHRpL29ianN0b3JlLmdv) | `0.00% <0.00%> (ø)` | | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1518/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)

crypto-org-chain / cronos

Problem: memiavl/versiondb don't build with upstream sdk #1518