yihuang commented 2 months ago

Solution:

extract standalone changes from #1575
use a simple and deterministic way to generate test accounts, no need to fund test accounts anymore.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

[ ] Have you read the CONTRIBUTING.md?
[ ] Does your PR follow the C4 patch requirements?
[ ] Have you rebased your work on top of the latest master?
[ ] Have you checked your code compiles? (make)
[ ] Have you included tests for any non-trivial functionality?
[ ] Have you checked your code passes the unit tests? (make test)
[ ] Have you checked your code formatting is correct? (go fmt)
[ ] Have you checked your basic code style is fine? (golangci-lint run)
[ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
[ ] If your changes affect the client infrastructure, have you run the integration test?
[ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
[ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
[ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

New Features
- Updated dependencies to the latest versions of the Cosmos SDK, enhancing performance and stability.
- Introduced new methods for account generation and conversion between Ethereum and Bech32 formats, improving flexibility in blockchain interactions.
- Added functionality for bulk processing of genesis accounts, streamlining account management.
- Enhanced node initialization and execution logic with global sequence tracking for better management of node identities.
- Added a new Balance class for improved representation of account balances.
Bug Fixes
- Removed outdated functions to simplify account creation processes.
Documentation
- Improved clarity on account initialization and transaction handling processes.

coderabbitai[bot] commented 2 months ago

Walkthrough

The pull request includes updates to the go.mod and gomod2nix.toml files, reflecting new versions and hashes for several Cosmos SDK dependencies. Additionally, modifications are made to several Python files in the testground/benchmark/benchmark directory, enhancing functions related to account generation, load testing, and node initialization. Notably, new parameters for global sequencing are introduced, improving the management of accounts and transactions across the testing framework.

Changes

Files	Change Summary
`go.mod`, `gomod2nix.toml`	Updated versions and hashes for Cosmos SDK dependencies to reflect the latest commits.
`testground/benchmark/benchmark/main.py`, `sendtx.py`	Modified `generate_load` function to include a new parameter `global_seq` for enhanced load generation.
`testground/benchmark/benchmark/peer.py`	Updated `init_node` to accept `global_seq`, improved account generation, and streamlined genesis account handling.
`testground/benchmark/benchmark/stateless.py`	Enhanced node initialization and execution logic by including a `global_seq` parameter across functions.
`testground/benchmark/benchmark/types.py`	Added a new `Balance` class and modified `GenesisAccount` to use a list of `Balance` instances.
`testground/benchmark/benchmark/utils.py`	Introduced functions for address conversion and deterministic account generation based on global sequence.

Possibly related PRs

#1431: Integrates Testground for network benchmarking, which may relate to the updates in the main PR that enhance dependency management for the Cosmos SDK.
#1561: Enhancements to the main.py file's generate_load function by adding a new parameter, relevant to dependency management updates.
#1574: Introduction of a new parameter for the gen_genesis function, aligning with overall genesis block management improvements.
#1576: Enhancements to the configuration logic for load generation, related to the updates involving dependency management.
#1578: Updates to the go.mod file, directly related to the changes made in the main PR regarding dependency versioning for the Cosmos SDK.

🐰 In the meadow, changes bloom,
Dependencies updated, dispelling gloom.
With sequences global, accounts align,
Testing flows smoothly, like sweet, fine wine.
A hop and a skip, the code's in its prime,
Hooray for the changes, it's testing time! 🌼

Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between e7417457d1d9b992993fe1dfe7e6479b77922b71 and 28439017b3d161105311d82c70beef8180901099.

Files selected for processing (1)

* testground/benchmark/benchmark/utils.py (3 hunks)

Files skipped from review as they are similar to previous changes (1)

* testground/benchmark/benchmark/utils.py

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.12%. Comparing base (559d7a7) to head (2843901). Report is 1 commits behind head on main.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1582/graphs/tree.svg?width=650&height=150&src=pr&token=92w0Dz1Coj&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1582 +/- ## =========================================== + Coverage 15.24% 36.12% +20.88% =========================================== Files 67 97 +30 Lines 4874 7725 +2851 =========================================== + Hits 743 2791 +2048 - Misses 4037 4585 +548 - Partials 94 349 +255 ``` [see 47 files with indirect coverage changes](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1582/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)

yihuang commented 2 months ago

seems validator doesnt generate when validator_generate_load is false?

WDYM?

crypto-org-chain / cronos