Problem: ibc channel upgrade related methods are not supported

[mmsqe]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• [ ] Have you read the CONTRIBUTING.md?
• [ ] Does your PR follow the C4 patch requirements?
• [ ] Have you rebased your work on top of the latest master?
• [ ] Have you checked your code compiles? (make)
• [ ] Have you included tests for any non-trivial functionality?
• [ ] Have you checked your code passes the unit tests? (make test)
• [ ] Have you checked your code formatting is correct? (go fmt)
• [ ] Have you checked your basic code style is fine? (golangci-lint run)
• [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• [ ] If your changes affect the client infrastructure, have you run the integration test?
• [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Introduced support for IBC (Inter-Blockchain Communication) channel upgrade methods, enhancing channel management capabilities.
  • Added new methods for querying and upgrading IBC channels, improving flexibility in operations.

• Bug Fixes

  • Enhanced error handling for Inter-Chain Accounts (ICA) registration on active channels.

• Tests

  • Expanded test functionalities to include processes for upgrading incentivized channels and improved error handling in ICA tests.

[coderabbitai[bot]]

Walkthrough

The changes introduce new functionality to support Inter-Blockchain Communication (IBC) channel upgrades across various modules and integration tests. Key updates include the addition of methods for upgrading IBC channels, modifications to existing functions for enhanced flexibility, and improvements in test cases to accommodate these new features. The updates are reflected in the changelog and involve changes to several files, enhancing the overall capability to manage IBC operations.

Changes

Files	Change Summary
CHANGELOG.md	Added a new feature for IBC channel upgrade methods, with references to pull request #1612.
integration_tests/cosmoscli.py	Introduced new methods for IBC operations, updated module_address to accept a prefix, and added functionality for upgrading and querying IBC channels.
integration_tests/ibc_utils.py	Added register_fee_payee function for fee registration logic, and modified register_acc to return port_id along with ica_address and channel_id.
integration_tests/test_ibc.py	Enhanced test_ibc_incentivized_transfer to include a temporary file for proposals and added logic for upgrading incentivized channels.
integration_tests/test_ica.py	Updated test_ica to handle IBC channel upgrades, including error handling and temporary file usage.
integration_tests/test_ica_incentivized.py	Modified return values of register_acc in the test_incentivized function to capture additional data.
x/cronos/middleware/conversion_middleware.go	Added methods to IBCConversionModule for handling various stages of IBC channel upgrades, including initialization and acknowledgment.

Possibly related PRs

• #1462: Introduces methods for handling IBC channel upgrades, directly related to the new feature in the main PR.
• #1464: Updates to the Cosmos SDK version may impact IBC functionality relevant to the main PR's changes.
• #1570: Changes regarding block-stm performance improvements may indirectly relate to the performance of IBC operations affected by the new methods.
• #1582: Enhancements in account generation and management could relate to testing the new IBC channel upgrade methods.

Suggested reviewers

• devashishdxt
• yihuang
• thomas-nguy

Poem

🐰 In the land of code where rabbits hop,
New IBC features make our hearts stop!
Channels upgrade with a flick of a paw,
Testing and tweaking, we’re in awe!
Hopping through changes, we dance with glee,
In the world of blockchain, we’re wild and free! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 36.88%. Comparing base (3d3cfed) to head (21e2278). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
x/cronos/middleware/conversion_middleware.go	0.00%	20 Missing :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1612 +/- ## ========================================== - Coverage 36.97% 36.88% -0.10% ========================================== Files 102 102 Lines 8035 8055 +20 ========================================== Hits 2971 2971 - Misses 4686 4706 +20 Partials 378 378 ``` | [Files with missing lines](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1612?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [x/cronos/middleware/conversion\_middleware.go](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1612?src=pr&el=tree&filepath=x%2Fcronos%2Fmiddleware%2Fconversion_middleware.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#diff-eC9jcm9ub3MvbWlkZGxld2FyZS9jb252ZXJzaW9uX21pZGRsZXdhcmUuZ28=) | `3.57% <0.00%> (-0.78%)` | :arrow_down: |