mmsqe commented 1 month ago

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

For more info

PR Checklist:

[ ] Have you read the CONTRIBUTING.md?
[ ] Does your PR follow the C4 patch requirements?
[ ] Have you rebased your work on top of the latest master?
[ ] Have you checked your code compiles? (make)
[ ] Have you included tests for any non-trivial functionality?
[ ] Have you checked your code passes the unit tests? (make test)
[ ] Have you checked your code formatting is correct? (go fmt)
[ ] Have you checked your basic code style is fine? (golangci-lint run)
[ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
[ ] If your changes affect the client infrastructure, have you run the integration test?
[ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
[ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
[ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

Release Notes

New Features
- Introduced a new parameter, header_hash_num, to enhance EVM module functionality and API documentation.
- Added support for IBC channel upgrade methods.
Improvements
- Optimized performance by adjusting default parallelism settings.
- Updated Ethermint to improve API call efficiency and transaction validation.
Bug Fixes
- Resolved issues with multisig accounts and incorrect address queries.
- Fixed unsupported sign mode for bank transfers.
Documentation
- Updated changelog to reflect new versioning and significant changes.

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request includes updates across several files, primarily focusing on enhancements and bug fixes. Key changes involve modifications to the CHANGELOG.md to document improvements, including performance optimizations and bug resolutions. The app/upgrades.go file has been updated to handle EVM parameters during upgrades. Additionally, the Swagger documentation has been enhanced with a new field, header_hash_num. Dependency management has been updated in go.mod and gomod2nix.toml, while the integration tests have been refined for better clarity and organization. A new field has also been added to the EVM parameters in the protocol buffer definition.

Changes

File	Change Summary
CHANGELOG.md	Updated to reflect improvements, bug fixes, and new version `v1.4.0-rc0`.
app/upgrades.go	Modified `RegisterUpgradeHandlers` to handle EVM parameters and added error handling.
client/docs/swagger-ui/swagger.yaml	Added `header_hash_num` field in paths and definitions for EVM module.
go.mod	Updated Go toolchain and various module dependencies, including `github.com/evmos/ethermint`.
gomod2nix.toml	Updated module versions and hashes for dependencies, particularly `github.com/evmos/ethermint`.
integration_tests/test_upgrade.py	Introduced `assert_evm_params` function and refined assertions related to EVM parameters.
third_party/proto/ethermint/evm/v1/params.proto	Added `header_hash_num` field to `Params` message in EVM package.

Possibly related PRs

#1462: Addresses the addition of support for packed batch calls in the relayer precompile.
#1569: Updates the changelog to document recent RPC fixes.
#1578: Documents the release of version 1.4.0-rc0, relevant to the main PR's updates.
#1592: Introduces changes to default parallelism settings, related to performance optimization.
#1600: Updates Ethermint to avoid unnecessary block results in header-related API calls.
#1612: Adds support for IBC channel upgrade methods.
#1614: Addresses the update of the cosmos-sdk to version 0.50.10.

Suggested reviewers

devashishdxt
calvinaco
yihuang

Poem

Hop hop, the changes are here,
With upgrades and fixes, we cheer!
A new field to guide,
In EVM we confide,
For smoother paths, let’s persevere! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.86%. Comparing base (c96cdaf) to head (04b239b). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
app/upgrades.go	0.00%	4 Missing :warning:

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1621/graphs/tree.svg?width=650&height=150&src=pr&token=92w0Dz1Coj&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1621 +/- ## ========================================== - Coverage 36.88% 36.86% -0.02% ========================================== Files 102 102 Lines 8055 8059 +4 ========================================== Hits 2971 2971 - Misses 4706 4710 +4 Partials 378 378 ``` | [Files with missing lines](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1621?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [app/upgrades.go](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1621?src=pr&el=tree&filepath=app%2Fupgrades.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#diff-YXBwL3VwZ3JhZGVzLmdv) | `15.38% <0.00%> (-2.80%)` | :arrow_down: |

crypto-org-chain / cronos

Problem: fix of broken opBlockhash and tx validation are not included #1621