Problem: ica query not tested

[yihuang]

Solution:

• test module safe query

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• [ ] Have you read the CONTRIBUTING.md?
• [ ] Does your PR follow the C4 patch requirements?
• [ ] Have you rebased your work on top of the latest master?
• [ ] Have you checked your code compiles? (make)
• [ ] Have you included tests for any non-trivial functionality?
• [ ] Have you checked your code passes the unit tests? (make test)
• [ ] Have you checked your code formatting is correct? (go fmt)
• [ ] Have you checked your basic code style is fine? (golangci-lint run)
• [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• [ ] If your changes affect the client infrastructure, have you run the integration test?
• [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Enhanced blockchain configurations for cronos_777-1 and chainmain-1, including new parameters for message handling and account definitions.
  • Introduced functionality for querying interchain account balances.
  • Added support for new message types in interchain accounts.

• Bug Fixes

  • Improved testing capabilities by adding balance query verification after transactions.

• Documentation

  • Updated configuration documentation to reflect recent changes in blockchain setups.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 17.87%. Comparing base (fb902d2) to head (493cbba). Report is 1 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (fb902d2) and HEAD (493cbba). Click for more details.

HEAD has 5 uploads less than BASE

| Flag | BASE (fb902d2) | HEAD (493cbba) | |------|------|------| ||2|0| |integration_tests|13|10|

Additional details and impacted files

[](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1635 +/- ## =========================================== - Coverage 36.31% 17.87% -18.44% =========================================== Files 123 72 -51 Lines 9715 5168 -4547 =========================================== - Hits 3528 924 -2604 + Misses 5773 4121 -1652 + Partials 414 123 -291 ``` [see 69 files with indirect coverage changes](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1635/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)

[coderabbitai[bot]]

Walkthrough

The changes in this pull request involve updates to the integration_tests/configs/ibc.jsonnet, integration_tests/ibc_utils.py, integration_tests/test_ica.py, and integration_tests/test_ica_precompile.py files. Modifications include enhancements to blockchain configurations for cronos_777-1 and chainmain-1, the introduction of a new class and function for querying interchain account balances, and the addition of testing functions to validate these queries. These changes collectively improve the functionality and testing capabilities related to interchain account management.

Changes

File	Change Summary
integration_tests/configs/ibc.jsonnet	Updated configurations for cronos_777-1 and chainmain-1, including new coin entry, message types, and parameters.
integration_tests/ibc_utils.py	Added QueryBalanceRequest class and gen_query_balance_packet function for querying interchain account balances.
integration_tests/test_ica.py	Introduced call_module_safe_query function to query interchain account balance after transactions.
integration_tests/test_ica_precompile.py	Utilized gen_query_balance_packet in test_sc_call to enhance balance verification after transaction submissions.

Possibly related PRs

• #1458: Modifies integration_tests/configs/ibc.jsonnet, indicating potential overlap in configuration changes.
• #1569: Focuses on RPC fixes but involves changes to integration_tests/ibc_utils.py, relevant to the main PR.
• #1582: Discusses improvements in account generation, relating to account definitions in the main PR.
• #1587: Changes in sendtx.py regarding transaction handling, connecting with message handling enhancements in the main PR.
• #1630: Addresses changes in header hash handling, potentially relating to blockchain state management in the main PR.

Suggested reviewers

• devashishdxt
• calvinaco
• mmsqe

🐇 In the fields where the blockchains play,
New coins and messages come out to play.
With balances queried and tests that are bright,
We hop through the code, oh what a delight!
Configs and functions, all in a row,
Enhancing our world, watch our systems grow! 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.