Problem: node can't shutdown by signal

[yihuang]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• [ ] Have you read the CONTRIBUTING.md?
• [ ] Does your PR follow the C4 patch requirements?
• [ ] Have you rebased your work on top of the latest master?
• [ ] Have you checked your code compiles? (make)
• [ ] Have you included tests for any non-trivial functionality?
• [ ] Have you checked your code passes the unit tests? (make test)
• [ ] Have you checked your code formatting is correct? (go fmt)
• [ ] Have you checked your basic code style is fine? (golangci-lint run)
• [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• [ ] If your changes affect the client infrastructure, have you run the integration test?
• [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Resolved an issue preventing the node from shutting down via signal.
  • Corrected query for address-by-account number and addressed multisig account issues.

• Improvements

  • Enhanced transaction handling with parallel generation of test transactions.
  • Updated various dependencies for better compatibility and performance, including significant updates to the Ethermint module and PebbleDB support.
  • Improved logging clarity during application shutdown.

• Documentation

  • Updated changelog to reflect ongoing development efforts and detailed changes across multiple versions.

• Tests

  • Added new test for local state synchronization and enhanced existing tests for transaction handling and error management.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.94%. Comparing base (007077a) to head (7432f50). Report is 1 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1647 +/- ## ======================================= Coverage 34.94% 34.94% ======================================= Files 123 123 Lines 11803 11803 ======================================= Hits 4124 4124 Misses 7265 7265 Partials 414 414 ```

[coderabbitai[bot]]

Walkthrough

The pull request includes updates to the CHANGELOG.md, go.mod, and gomod2nix.toml files for the Cronos project. The changelog details bug fixes and improvements across multiple versions, including significant changes in the state machine and transaction handling. The go.mod file updates the Go version and various dependencies, while gomod2nix.toml reflects corresponding updates in module versions and hashes. These changes ensure compatibility with newer versions of dependencies and address identified issues.

Changes

File	Change Summary
CHANGELOG.md	Updated with bug fixes and improvements in the UNRELEASED, v1.4.0-rc1, v1.4.0-rc0, and earlier versions, including state machine changes, transaction handling improvements, and various bug fixes.
go.mod	Updated Go version from 1.22.2 to 1.22.3. Modified dependencies: github.com/evmos/ethermint version updated, github.com/99designs/keyring replaced with github.com/cosmos/keyring, github.com/dgrijalva/jwt-go replaced with github.com/golang-jwt/jwt/v4, and updated github.com/ethereum/go-ethereum to a new version.
gomod2nix.toml	Updated module versions and hashes for github.com/evmos/ethermint and github.com/ethereum/go-ethereum, marking the latter as replaced with github.com/crypto-org-chain/go-ethereum. Other modules also received version and hash updates, indicating a comprehensive refresh of dependencies.

Possibly related PRs

• #1600: This PR updates the Ethermint module to avoid unnecessary block results in header-related API calls, which is directly related to the improvements noted in the main PR's changelog.
• #1618: This PR addresses the compatibility of the memiavl module with iavl 1.2.0, which is a significant change mentioned in the main PR's changelog.
• #1648: This PR introduces a new feature to allow the abort of operations in the PrepareProposal function, which aligns with the improvements highlighted in the main PR's changelog regarding the PrepareProposal process.

Suggested reviewers

• yihuang

Poem

In the garden of code, where changes bloom,
Dependencies dance, dispelling the gloom.
With updates and fixes, our project takes flight,
Bugs are now banished, all feels just right.
So hop with delight, let the changelog sing,
For Cronos is thriving, and joy it will bring! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[mmsqe]

test_local_statesync seems flaky now