Problem: check-tx blocks consensus

[yihuang]

support optional NewConnSyncLocalClientCreator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• [ ] Have you read the CONTRIBUTING.md?
• [ ] Does your PR follow the C4 patch requirements?
• [ ] Have you rebased your work on top of the latest master?
• [ ] Have you checked your code compiles? (make)
• [ ] Have you included tests for any non-trivial functionality?
• [ ] Have you checked your code passes the unit tests? (make test)
• [ ] Have you checked your code formatting is correct? (go fmt)
• [ ] Have you checked your basic code style is fine? (golangci-lint run)
• [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• [ ] If your changes affect the client infrastructure, have you run the integration test?
• [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• Improvements

  • Added support for registering payees and counterparty payees in the relayer precompile.
  • Enhanced transaction verification with support for asynchronous transaction checks.
  • Updated dependencies, including cometbft to version 0.38.13, to improve performance and security.

• Documentation

  • Updated CHANGELOG to include a new "UNRELEASED" section, documenting recent changes and improvements.

These updates aim to enhance functionality, improve transaction handling, and maintain comprehensive documentation for users.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.17%. Comparing base (27f1a59) to head (9ecf926). Report is 1 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1660?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1660 +/- ## ======================================= Coverage 35.17% 35.17% ======================================= Files 123 123 Lines 11740 11740 ======================================= Hits 4129 4129 Misses 7197 7197 Partials 414 414 ```

[coderabbitai[bot]]

Walkthrough

The pull request introduces updates across several files, including the addition of a new "UNRELEASED" section in CHANGELOG.md to document improvements in asynchronous transaction checking. The go.mod file has been updated for dependency management, including version updates and replacements for several packages. Similarly, gomod2nix.toml reflects changes in module dependencies. Lastly, a modification in testground/benchmark/benchmark/stateless.py adds the --async-check-tx flag to the command for starting the cronosd node.

Changes

File	Change Summary
CHANGELOG.md	New section "UNRELEASED" added; noted feature for registering payees linked to PR #1665; improvements for async transaction checks linked to PR #1660; cometbft update linked to PR #1664.
go.mod	Updated Go toolchain from go1.22.3 to go1.23.1; various dependency updates and replacements.
gomod2nix.toml	Updated versions and hashes for multiple Go modules, including github.com/evmos/ethermint.
testground/benchmark/benchmark/stateless.py	Added --async-check-tx flag to cronosd startup command.

Possibly related PRs

• #1665: The main PR mentions support for registering payees in the relayer precompile, which is directly related to the changes in this PR that also address payee configurations.
• #1660: The main PR includes improvements for asynchronous transaction checks, which aligns with the changes in this PR that enhance transaction handling and efficiency.
• #1664: The main PR references an update to the cometbft version, which is also noted in this PR as part of the dependency updates.
• #1650: The main PR's mention of batch transaction support relates to this PR, which introduces batch mode functionality in the benchmark.
• #1651: The main PR's focus on performance improvements when broadcasting transactions connects to this PR, which enhances the efficiency of the cometbft RPC for transaction broadcasting.
• #1654: The main PR's changes regarding payees are directly related to this PR, which addresses the configuration of payees for relayer callers.
• #1655: The main PR's updates on state overwrites in debug traces are relevant to this PR, which includes fixes for state overwrites.
• #1658: The main PR's improvements for scenarios where the blocklist is empty relate to this PR, which introduces optimizations for such cases.
• #1659: The main PR's mention of skipping check-tx in benchmarks is directly connected to this PR, which adds support for that functionality.
• #1661: The main PR's focus on the release status of version 1.4.0-rc2 is relevant to this PR, which addresses the same issue.

Suggested reviewers

• calvinaco
• devashishdxt
• mmsqe

Poem

🐰 In the meadow, changes bloom,
With async checks, we clear the gloom.
Dependencies dance, versions align,
In our code, the stars brightly shine.
Hopping forward, we embrace the new,
A brighter path for all to pursue! 🌼

---

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Files that changed from the base of the PR and between 02c1a1c7f6de20ee8628da20e66ff847fb43c161 and 9ecf9269113c49c89e78fdd0cc1a6c0fe26aa622.

⛔ Files ignored due to path filters (1)

* `go.sum` is excluded by `!**/*.sum`

📒 Files selected for processing (3)

* CHANGELOG.md (1 hunks) * go.mod (1 hunks) * gomod2nix.toml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

* CHANGELOG.md * go.mod * gomod2nix.toml

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.