yihuang commented 3 weeks ago

Solution:

add several optimizations in dependencies: a) async fireEvents, b) faster prepare proposal when using NopMempool, c) parallel check-tx

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

[ ] Have you read the CONTRIBUTING.md?
[ ] Does your PR follow the C4 patch requirements?
[ ] Have you rebased your work on top of the latest master?
[ ] Have you checked your code compiles? (make)
[ ] Have you included tests for any non-trivial functionality?
[ ] Have you checked your code passes the unit tests? (make test)
[ ] Have you checked your code formatting is correct? (go fmt)
[ ] Have you checked your basic code style is fine? (golangci-lint run)
[ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
[ ] If your changes affect the client infrastructure, have you run the integration test?
[ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
[ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
[ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

Release Notes

New Features
- Added support for registering payee and counterpartyPayee in the relayer precompile.
Improvements
- Enhanced performance for asynchronous event firing and proposal preparation.
- Updated dependencies to improve compatibility and performance.
- Introduced a testnet benchmark command for better performance evaluation.
- Implemented parallel generation of test transactions and improved load generator behavior.
- Enhanced transaction validation process with byte data for more robust handling.
Bug Fixes
- Resolved issues with single validator benchmarks and ensured proper node shutdown.
- Fixed state overwrites in debug trace APIs and improved transaction validation logic.
- Addressed issues with multisig accounts and unsupported sign modes.

These changes enhance the application's functionality and performance, providing a more reliable user experience.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The pull request introduces multiple updates across several files, primarily focusing on enhancements to the proposal handling mechanism, transaction validation, and dependency management. Key changes include the addition of support for registering payees in the relayer precompile, optimizations in proposal handling, and updates to the go.mod and gomod2nix.toml files to reflect new versions of dependencies. The changelog has been updated to document these new features, improvements, and bug fixes across various releases.

Changes

File	Change Summary
CHANGELOG.md	Updated to include new features, improvements, and bug fixes across releases, including support for payee registration and performance optimizations.
app/app.go	Modified the `New` function to use `baseapp.NewDefaultProposalHandlerFast` for optimized proposal handling.
app/proposal.go	Updated transaction validation methods to include byte representation; added `SelectTxForProposalFast` method.
go.mod	Updated Go version and various dependencies to newer versions, including `golang.org/x/crypto` and `google.golang.org/grpc`.
gomod2nix.toml	Updated module versions and hashes for dependencies, ensuring integrity and compatibility with new versions.
app/proposal_test.go	Introduced new test file with mock transaction selector and unit tests for `SelectTxForProposalFast`.

Possibly related PRs

#1665: This PR introduces support for registering payees and counterparty payees in the relayer precompile, which is directly related to the new feature added in the main PR.
#1651: This PR discusses improvements in broadcasting transactions using the cometbft RPC, which aligns with the enhancements made in the main PR regarding performance optimizations.
#1658: This PR addresses performance optimizations when the block-list is empty, which is relevant to the performance improvements mentioned in the main PR.
#1660: This PR focuses on the check-tx feature that blocks consensus, which may relate to the asynchronous transaction checks introduced in the main PR.
#1667: This PR adds a testnet benchmark command, which complements the improvements and new features documented in the main PR.
#1668: This PR modifies the benchmark block stats detection mechanism, which is relevant to the performance optimizations discussed in the main PR.

Suggested reviewers

calvinaco
mmsqe
devashishdxt

Poem

🐇 In the meadow where rabbits play,
New features hop in, brightening the day!
With faster proposals and checks that are keen,
Our code now dances, agile and lean.
Dependencies updated, all in a row,
Let’s celebrate changes, watch our project grow! 🌼

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between 2d0b7315e99836ce66e03fa7c07fd1dd0183b876 and 1fe74b7880fe8d0da33f82ddb8215195aef29203.

⛔ Files ignored due to path filters (1)

* `go.sum` is excluded by `!**/*.sum`

📒 Files selected for processing (4)

* `CHANGELOG.md` (1 hunks) * `go.mod` (5 hunks) * `gomod2nix.toml` (7 hunks) * `integration_tests/ibc_utils.py` (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

* CHANGELOG.md * go.mod * gomod2nix.toml

🔇 Additional comments (2)

integration_tests/ibc_utils.py (2)

`167-167`: **LGTM! Improved code organization.** Moving the CLI initialization outside the conditional block makes it available throughout the function scope, improving code organization and reducing redundancy. --- `184-185`: **LGTM! Enhanced test stability.** The addition of explicit waits for new blocks on both chains is a good defensive programming practice. This ensures that both networks are stable and synchronized before proceeding with further operations, preventing potential race conditions in the tests.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 35.27%. Comparing base (b6063d4) to head (1fe74b7). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
app/proposal.go	65.38%	9 Missing :warning:

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1669/graphs/tree.svg?width=650&height=150&src=pr&token=92w0Dz1Coj&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1669 +/- ## =========================================== + Coverage 16.88% 35.27% +18.38% =========================================== Files 72 123 +51 Lines 6149 11752 +5603 =========================================== + Hits 1038 4145 +3107 - Misses 4988 7193 +2205 - Partials 123 414 +291 ``` | [Files with missing lines](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1669?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [app/proposal.go](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1669?src=pr&el=tree&filepath=app%2Fproposal.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#diff-YXBwL3Byb3Bvc2FsLmdv) | `32.45% <65.38%> (+11.86%)` | :arrow_up: | ... and [69 files with indirect coverage changes](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1669/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)

crypto-org-chain / cronos

Problem: recent optimizations not included #1669