yihuang commented 2 weeks ago

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

[ ] Have you read the CONTRIBUTING.md?
[ ] Does your PR follow the C4 patch requirements?
[ ] Have you rebased your work on top of the latest master?
[ ] Have you checked your code compiles? (make)
[ ] Have you included tests for any non-trivial functionality?
[ ] Have you checked your code passes the unit tests? (make test)
[ ] Have you checked your code formatting is correct? (go fmt)
[ ] Have you checked your basic code style is fine? (golangci-lint run)
[ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
[ ] If your changes affect the client infrastructure, have you run the integration test?
[ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
[ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
[ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

New Features
- Introduced new validators for rollback testing, enhancing the configuration options.
Bug Fixes
- Improved the rollback testing logic to accommodate multiple nodes, increasing scalability and maintainability.
Refactor
- Renamed and generalized the command update function to handle multiple nodes, streamlining the test process.

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request modifies the configuration of validators in integration_tests/configs/rollback.jsonnet, replacing the 'fullnode' validator with 'rollback-test-memiavl' and introducing a new 'rollback-test-iavl' validator. Additionally, it updates the test logic in integration_tests/test_rollback.py by renaming the update_node2_cmd function to update_node_cmd for improved scalability and generalization, allowing it to handle multiple nodes. The test logic is further enhanced to dynamically manage commands for both nodes 2 and 3.

Changes

File	Change Summary
integration_tests/configs/rollback.jsonnet	- Replaced validator 'fullnode' with 'rollback-test-memiavl' (enabled `memiavl`). - Added new validator 'rollback-test-iavl' (disabled `memiavl`).
integration_tests/test_rollback.py	- Renamed function `update_node2_cmd` to `update_node_cmd` for handling multiple nodes. - Updated `test_rollback` logic to support dynamic handling of nodes 2 and 3.

Possibly related PRs

1620: The changes in memiavl/db.go regarding the handling of change sets may relate to the memiavl feature mentioned in the main PR, as both involve modifications to the memiavl functionality.
1673: This PR addresses a bug related to the iavl dependency, which is relevant to the changes in validator configurations in the main PR that involve memiavl and iavl features.

Suggested reviewers

calvinaco
mmsqe
thomas-nguy

Poem

In the meadow, changes bloom,
Validators shift, dispelling gloom.
From 'fullnode' to 'rollback-test',
New commands for nodes, we do our best!
With each update, our code takes flight,
Hopping forward, all feels right! 🐇✨

[!WARNING]

Rate limit exceeded

@yihuang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

📥 Commits
Reviewing files that changed from the base of the PR and between 3e109f43a7886eb1ac40d45b9e84303cfcac1c86 and b355ad443cee6a9207ed010fcc443ee53b42d9ec.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 11.63%. Comparing base (6dc645a) to head (b355ad4). Report is 1 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (6dc645a) and HEAD (b355ad4). Click for more details.

HEAD has 21 uploads less than BASE
| Flag | BASE (6dc645a) | HEAD (b355ad4) | |------|------|------| ||2|0| |integration_tests|20|1|

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1693/graphs/tree.svg?width=650&height=150&src=pr&token=92w0Dz1Coj&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1693 +/- ## =========================================== - Coverage 35.47% 11.63% -23.85% =========================================== Files 124 72 -52 Lines 11893 6163 -5730 =========================================== - Hits 4219 717 -3502 + Misses 7251 5395 -1856 + Partials 423 51 -372 ``` [see 84 files with indirect coverage changes](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1693/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)

crypto-org-chain / cronos

Problem: iavl rollback not tested #1693

PR Checklist:

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

1620: The changes in `memiavl/db.go` regarding the handling of change sets may relate to the `memiavl` feature mentioned in the main PR, as both involve modifications to the `memiavl` functionality.

1673: This PR addresses a bug related to the `iavl` dependency, which is relevant to the changes in validator configurations in the main PR that involve `memiavl` and `iavl` features.

Suggested reviewers

Poem

Rate limit exceeded

Codecov Report

crypto-org-chain / cronos

Problem: iavl rollback not tested #1693

PR Checklist:

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

1620: The changes in memiavl/db.go regarding the handling of change sets may relate to the memiavl feature mentioned in the main PR, as both involve modifications to the memiavl functionality.

1673: This PR addresses a bug related to the iavl dependency, which is relevant to the changes in validator configurations in the main PR that involve memiavl and iavl features.

Suggested reviewers

Poem

Rate limit exceeded

Codecov Report

1620: The changes in `memiavl/db.go` regarding the handling of change sets may relate to the `memiavl` feature mentioned in the main PR, as both involve modifications to the `memiavl` functionality.

1673: This PR addresses a bug related to the `iavl` dependency, which is relevant to the changes in validator configurations in the main PR that involve `memiavl` and `iavl` features.