Problem: max-tx-gas-wanted is checked in consensus logic

[yihuang]

Solution:

• revert the change to check-tx mode only
• release v1.4.0-rc5 breaking upgrade.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• [ ] Have you read the CONTRIBUTING.md?
• [ ] Does your PR follow the C4 patch requirements?
• [ ] Have you rebased your work on top of the latest master?
• [ ] Have you checked your code compiles? (make)
• [ ] Have you included tests for any non-trivial functionality?
• [ ] Have you checked your code passes the unit tests? (make test)
• [ ] Have you checked your code formatting is correct? (go fmt)
• [ ] Have you checked your basic code style is fine? (golangci-lint run)
• [ ] If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• [ ] If your changes affect the client infrastructure, have you run the integration test?
• [ ] If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• [ ] If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• [ ] If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

Release Notes for Version v1.4.0-rc5

• New Features

  • Introduced a new upgrade handler for the testnet environment, simplifying the upgrade process.

• Improvements

  • Updated changelog to highlight significant changes in transaction processing related to max-tx-gas-wanted.
  • Enhanced dependency management by updating several package versions for improved stability and performance.

These changes aim to enhance the overall functionality and reliability of the system.

[coderabbitai[bot]]

Walkthrough

This pull request introduces several changes, including an update to the changelog for version v1.4.0-rc5, which highlights a significant modification in the state machine regarding the max-tx-gas-wanted parameter, now only checked in CheckTx mode. Additionally, a new upgrade handler for a hotfix upgrade plan named "v1.4.0-rc5-testnet" is added to app/upgrades.go. The go.mod file is updated to reflect various dependency version changes and replacements.

Changes

File	Change Summary
CHANGELOG.md	Added entry for version v1.4.0-rc5 regarding changes to max-tx-gas-wanted handling in the state machine.
app/upgrades.go	Introduced new upgrade handler for "v1.4.0-rc5-testnet" in RegisterUpgradeHandlers method.
go.mod	Updated dependency versions and added replacements for several packages, including github.com/evmos/ethermint.

Possibly related PRs

• #1484: Addresses the functionality of the max_gas_wanted parameter, directly related to changes in handling the max-tx-gas-wanted.
• #1487: Focuses on the max_gas_wanted parameter, indicating a connection to transaction processing changes in the main PR.
• #1503: Discusses the mempool.max-txs flag, relevant to transaction handling and gas management.
• #1614: Mentions updates to the SDK version and improvements in transaction handling, aligning with changes affecting transaction validation.
• #1655: Includes a fix for state overwrite issues in debug trace APIs, connecting to state machine logic changes.
• #1690: Consolidates bug fixes related to balance and gas price handling in the debug trace API, relevant to transaction processing logic.

Suggested reviewers

• devashishdxt
• thomas-nguy

🐰 In the code, I hop and play,
With gas limits, I find my way.
A new handler joins the fun,
Upgrades now can swiftly run!
Changelog bright, with changes clear,
In the land of code, we cheer! 🎉

[!WARNING]

Rate limit exceeded

@yihuang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ce797fa995000530ee53cd1fbeb3c67180648002 and d0388e4a0b2c224672930648c484a93ef61dc08a.

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint

level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.47%. Comparing base (a3c2f70) to head (d0388e4). Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
app/upgrades.go	25.00%	2 Missing and 1 partial :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) ```diff @@ Coverage Diff @@ ## main #1697 +/- ## =========================================== + Coverage 16.87% 35.47% +18.59% =========================================== Files 72 124 +52 Lines 6163 11897 +5734 =========================================== + Hits 1040 4220 +3180 - Misses 5000 7253 +2253 - Partials 123 424 +301 ``` | [Files with missing lines](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1697?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain) | Coverage Δ | | |---|---|---| | [app/upgrades.go](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1697?src=pr&el=tree&filepath=app%2Fupgrades.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain#diff-YXBwL3VwZ3JhZGVzLmdv) | `44.30% <25.00%> (+38.97%)` | :arrow_up: | ... and [70 files with indirect coverage changes](https://app.codecov.io/gh/crypto-org-chain/cronos/pull/1697/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crypto-org-chain)