crypto-org-chain / cronos

Cronos is the first Ethereum-compatible blockchain network built on Cosmos SDK technology. Cronos aims to massively scale the DeFi, GameFi, and overall Web3 user community by providing builders with the ability to instantly port apps and crypto assets from other chains while benefiting from low transaction fees, high throughput, and fast finality.
Other
290 stars 235 forks source link

Problem: make gen-cronos-contracts does not uses the latest solidity compiler #603

Open thomas-nguy opened 2 years ago

thomas-nguy commented 2 years ago

Upgrade compiler to be able to use v0.8x

yihuang commented 2 years ago

I think this one is fixed right?

thomas-nguy commented 2 years ago

no it is still using 0.6.8

I think we need at least 0.8.1

https://github.com/crypto-org-chain/cronos/blob/main/contracts/shell.nix#L7

yihuang commented 2 years ago

ah, you mean the ModuleCRC

yihuang commented 2 years ago

the main blocker is the ds-token only support up to 0.6.x, an alternative is to switch to openzeppelin.

yihuang commented 2 years ago

is there a specific issue with older compilers?

thomas-nguy commented 2 years ago

hmm maybe its okay but for the standard sake, maybe it would be better to use the latest version