Cleanup dex market page

crypto-power / cryptopower

A cross-platform SPV (DCR, BTC & LTC) privacy wallet built with go.

ISC License

43 stars 28 forks source link

Cleanup dex market page #692

Closed ukane-philemon closed 1 month ago

ukane-philemon commented 1 month ago

Don't read feed channel from pg.selectedMarketOrderbook
Remove unused code
Calculate dex order by lot
Display order Amount: this will make it less confusing for user when calculating what they get with amount of lots they want.

Screenshot is stale: Quantity -> Amount

norwnd commented 1 month ago

Hey @ukane-philemon I've briefly took a look at https://github.com/crypto-power/cryptopower/issues/690 and noticed there is quite a bit of concurrent interaction happening with `DEXMarketPage struct` but not enough syncronization between go-routines involved,

I don't plan to investigate those myself, just pointing out this is probably needs addressing and that it can cause https://github.com/crypto-power/cryptopower/issues/690 and similar issues.