crypto-utils / keygrip

Key signing and verification for rotated credentials
MIT License
931 stars 49 forks source link

Use crypto#getCiphers and crypto#getHashes #21

Closed ThisIsMissEm closed 9 years ago

ThisIsMissEm commented 9 years ago

Currently the code seems to be using a method of "try actually using this cipher or hash and if it throws, report it as an unavailable option".

It seems that using Crypto#getCiphers and Crypto#getHashes would be the better route for doing this.

Is there a reason to not use those?

ThisIsMissEm commented 9 years ago

Uh, perhaps ignore this, I kind of missed the logic that was actually been being used.

Looks like it's for backwards compatibility.