Make it work on both Debian-derived systems (using nodejs binary) and other systems (using node binary)

crypto-utils / keygrip

Key signing and verification for rotated credentials

MIT License

931 stars 49 forks source link

Make it work on both Debian-derived systems (using nodejs binary) and other systems (using node binary) #9

Closed jwatte closed 11 years ago

jed commented 11 years ago

Awesome, thanks @jwatte.

ggoodale commented 10 years ago

When attempting to install koajs/koa on windows (I know, I know), this change prevents install.js from executing unless npm is called from bash. (And, I suppose, this also affects everyone not using a bash-type shell on *nix, though that's probably an even smaller group of people.) node install.js works pretty much everywhere in every shell except debian at the moment - please consider reverting since debian users can (and probably do, frequently) symlink nodejs to node.

jed commented 10 years ago

i think we're better off getting rid of the install script. the only thing it does is provide keys if none are specified. i'd rather throw if they're missing, so that we can do without the script entirely.

would you be willing to tee that up in a PR?

ggoodale commented 10 years ago

Seems reasonable to me - Have a look at PR #11.