search

crypto101 / book

Crypto 101, the introductory book on cryptography.
https://www.crypto101.io/
Other
3.01k stars 192 forks source link

Add release job to GHA CI #418

Closed gliptak closed 3 years ago

gliptak commented 3 years ago

Signed-off-by: Gábor Lipták gliptak@gmail.com

git tag v0.6.1
git push origin tag v0.6.1
gliptak commented 3 years ago

i just noticed that the artifacts uploaded actually zip files. A single archive with pdf/epub/html included might work better. Thoughts?

https://github.com/crypto101/book/actions/runs/962709520

lvh commented 3 years ago

Definitely! We'd love to link to the releases directly.

gliptak commented 3 years ago

@lvh

this is how a release looks

https://github.com/gliptak/gha_buildcontainer/releases/tag/v0.2.1

multiarchive

https://github.com/crypto101/book/actions/runs/962709520

single archive

https://github.com/crypto101/book/actions/runs/962817249

please let me know which one you prefer

PS I'm running into https://github.com/actions/upload-artifact/issues/74

lvh commented 3 years ago

I think https://github.com/crypto101/book/actions/runs/962709520 is the best because it lets you download the individual files (PDF/EPUB...) directly.

gliptak commented 3 years ago

thanks @lvh the one thing to mention is that the individual files are still zipped up (which seem to be GH file upload functionality?)

I will repush that previous commit

gliptak commented 3 years ago

@lvh any updates you would like to see?