search

crypto101 / book

Crypto 101, the introductory book on cryptography.
https://www.crypto101.io/
Other
3.01k stars 192 forks source link

Advanced admonition is broken in pdf. #434

Open aaron-cooper opened 1 year ago

aaron-cooper commented 1 year ago

The grey box around the admonition is too short, which causes the text to leave the box along the top edge. Also the bottom of the propeller cap is nearly touching the bottom edge of the box.

I've attached an image that shows how it looks. The image is from the pdf generated with 53e27e97a22438ee2bbcc301f39b4bc2af28ba17 (master at the time of writing).

I bisected master to try and find where the issue is introduced, it seems to come from eebb93f02b02201e82772875b2768b690bc6587d, due to bumping ubuntu 20.04 to 22.04. If I change the version back to 20.04, rebuild the docker container, and generate the pdf, the issue goes away.

broken_admonition

lvh commented 1 year ago

Ugh; that's awfully frustrating. Overall it feels like the move to Sphinx has been a huge mistake; it just does not have the commitment to reliability this project needs.

Thanks for bringing it to my attention, but I'm not entirely sure what I'm going to do about this. Downgrade seems like an immediate option?

aaron-cooper commented 1 year ago

@lvh

Overall it feels like the move to Sphinx has been a huge mistake

For what it's worth, I submitted this https://github.com/sphinx-doc/sphinx/pull/11113 to sphinx. If they merge it, it should fix #419