cryptoadvance / specter-desktop

A desktop GUI for Bitcoin Core optimised to work with hardware wallets
MIT License
802 stars 238 forks source link

"Save wallet to file" escapes double quotes, rendering resulting json unusable #1005

Closed kdmukai closed 3 years ago

kdmukai commented 3 years ago

Running the latest from master.

Double quotes are escaped to ":

{ "label": "KeepKey-BitcoinCore Hot multisig", "blockheight": 671093, ...

Needs a safe and double quote filtering to yield valid json. Will be fixed alongside #948.

kdmukai commented 3 years ago

May address #840 once this one is fixed.

ben-kaufman commented 3 years ago

https://github.com/cryptoadvance/specter-desktop/pull/1007/commits/f5f425dd94702e843625a9a7eac2d30f4e16b59f

I believe I fixed it in this commit (which should've been a separate PR in retrospect...), could you please check it solves it for you?

k9ert commented 3 years ago

Solved in the pre-releases. Will close here, please reopen if it persists.