cryptoadvance / specter-desktop

A desktop GUI for Bitcoin Core optimised to work with hardware wallets
MIT License
793 stars 236 forks source link

Bitcore Core (Hot Wallet) option appears when it should not #1875

Open wombat6 opened 2 years ago

wombat6 commented 2 years ago

Describe the bug Specter Desktop incorrectly allows the user to add a Bitcoin Core hot wallet before the user has actually configured bitcoin core.

To Reproduce

  1. Preliminary: Be sure that bitcoin core is not configured in Specter Desktop
  2. Go to Add Wallet.
  3. Choose Manual Configuration
  4. In the dropdown, you will see Bitcoin Core (hot wallet)

Expected behavior Would not expect to see Bitcoin Core as an option before it's actually configured in

wombat6 commented 2 years ago

My suggestion would be to leave it in the dropdown, actually, but just disable it if bitcoin core isn't configured as the full node.