k9ert
commented
1 year ago For a strange reason, this is only a problem until specter is rebooted. Then it disappears. At least i know roughly what's the case here: the taproot transaction is not be considered as ismine. This is implemented like this:
@property
def ismine(self) -> bool:
if self.get("ismine"):
return self["ismine"]
inputs = self.psbt.inputs
outputs = self.psbt.outputs
any_inputs_mine = any([inp.is_mine for inp in inputs])
any_outputs_mine = any([out.is_mine for out in outputs])
self["ismine"] = any_inputs_mine or any_outputs_mine
return self["ismine"]The psbt is created like this:
@property
def psbt(self) -> SpecterPSBT:
"""This tx but as a psbt. Need rpc-calls"""
if hasattr(self, "_psbt"):
return self._psbt
self._psbt: SpecterPSBT = self.PSBTCls.from_transaction(
self.tx, self.descriptor, self.network
)
# fill derivation paths etc
updated = self.rpc.walletprocesspsbt(str(self._psbt), False).get("psbt", None)
if updated:
self._psbt.update(updated)
return self._psbtAs this needs to be an issue for the output as the output needs to be ismine, the SpecterOutputScope.ismine implementation:
@property
def is_mine(self) -> bool:
return self.descriptor.owns(self.scope)@stepansnigirev can you see any reason why taproot transactions have trouble here?
stepansnigirev
(Screenshot from revamp branch but same on master)
Steps to reproduce
Create a Taproot wallet, send regtest funds to it from a Segwit wallet to produce an UTXO for the Taproot wallet.
Stacktrace