search

cryptoadvance / specter-desktop

A desktop GUI for Bitcoin Core optimised to work with hardware wallets
MIT License
793 stars 236 forks source link

SWAN plugin is missing after upgrade to v2.0.0 #2296

Open aphex3k opened 1 year ago

aphex3k commented 1 year ago

Describe the bug I've updated my specter-desktop docker image to v2.0.0, restored the wallets, and re-scanned the blockchain successfully. All funds seem to be accounted for.

To Reproduce Steps to reproduce the behavior:

  1. Install lncm/specter-desktop:v1.14.2@sha256:47e18789aaf87dbfd1f313346cbde4d8fc982dace28f889f78c96f0d87b3ad9a
    • This is the version currently available on the Umbrel app store
  2. Create a (multisig) wallet using Bitcoin Core
    • Not sure if it has to be a multi-sig but that is all I use specter for 💯
    • I use n of m multi-sig with m - n > 1
  3. Connect the wallet to SWAN
  4. "Use the wallet"
  5. Upgrade to v2.0.0
  6. The wallet is missing, but can be restored using the on-screen UI
    • wait for the wallet to synchronize/scan completely
    • all transaction Labels are lost :(
    • all UTXO frozen status are lost :(
  7. Open Services > Add plugin
  8. The UI does not show SWAN
  9. Open Wallets
  10. Select the wallet that was previously connected to SWAN
  11. The wallet is missing the connection to SWAN

Expected behavior The wallet should stay connected to swan or should be able to be re-connected to SWAN.

Screenshots

Screenshot 2023-03-08 at 10 24 21 AM

Desktop:

Additional Context: I ran into the issue when upgrading my first wallet and was able to reproduce the same behavior during the upgrade of a second wallet with similar configuration. Looking at #2291, #2290, #2294, it seems it is not expected for SWAN to be missing even though it might not look correct. The Exfund Service plugin stayed enabled correctly after the upgrade.

moneymanolis commented 1 year ago

@aphex3k because of the issues you referred to, the plugin was reduced to beta status for the time being. Beta plugins are not shown by default in production. You can enable it (and all other beta plugins with it) using the Electron app, like so:

Not sure how to do enable this with the docker images, though. Perhaps @k9ert has an idea.

aphex3k commented 1 year ago

There is no Advanced on the Settings screen.

image

I'm running the Docker variant. I'd assume that is why it doesn't have CLI arg?

aphex3k commented 1 year ago

I added it to the docker-compose that is starting the container, and I can see SWAN now.

moneymanolis commented 1 year ago

Good idea, cool! And sorry for the confusion, it was a last minute decision to do this since we had to release. What's the status now on your Swan connected wallet?

aphex3k commented 1 year ago

Good idea, cool! And sorry for the confusion, it was a last minute decision to do this since we had to release. What's the status now on your Swan connected wallet?

I'm running into https://github.com/cryptoadvance/specter-desktop/issues/1963.

moneymanolis commented 1 year ago

No real surprise, since the redirect URIs have not been changed yet :-(

aphex3k commented 1 year ago

No real surprise, since the redirect URIs have not been changed yet :-(

So nothing I can do about it yet? I guess I have to wait?

moritzwietersheim commented 1 year ago

Hey @aphex3k, I am sorry we couldn't fix this in time for the release. I will try to see what we can do to fix this issue.

moneymanolis commented 1 year ago

I have reopened https://github.com/cryptoadvance/specter-desktop/issues/1963

aphex3k commented 1 year ago

@moneymanolis , @moritzwietersheim Is there any update on this? I had been able to connect my swan account at some point, but automated withdrawal seems broken. I see the below behavior in my dashboard.

withdrawal history

skwp commented 1 year ago

Hey @aphex3k is this a new issue? Can we open it separately? Can you see if the wallet you’re withdrawing to is confirmed? Go to /wallets on the swan side and you may need to do something to authorize it first.

skwp commented 1 year ago

You may need to go to the withdrawals or auto withdrawal section above the history to view the unconfirmed wallet. Apologies if this is the issue. We are investigating to see if there is a short term fix.