search

cryptoadvance / specter-desktop

A desktop GUI for Bitcoin Core optimised to work with hardware wallets
MIT License
793 stars 237 forks source link

Allow "Speed up" on transactions with a single output #2433

Closed leon-costa closed 4 months ago

leon-costa commented 5 months ago

This PR enables the fee bump feature on single-output transactions by reducing the output amount. Without it Specter complains that it can't bump fee in a transaction without change outputs.

This is meant to partially resolve #988. This issue is marked as resolved, but it's not because of #2377 (which seems to be much more complex to solve than what this PR does).

Multiple-output transactions without change are still not supported.

And there's no UI to warn you that the output amount is being reduced. I'm not sure that's necessary.

netlify[bot] commented 5 months ago

Deploy Preview for specter-desktop-docs canceled.

Name Link
Latest commit e2c24bc4b3ef0e9d945f4e6af286d5a87e7483f5
Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/6633af4860c65b00070ed30a
leon-costa commented 5 months ago

Do not hesitate to close this PR if you would rather have a complete fix for the whole issue. It's just that this is the second time I've needed this feature and since I have working code for it, I thought I'd share it in case you or anyone else wants it.

k9ert commented 5 months ago

Thanks for your contribution and sorry for the delay. Very much appreciated!

k9ert commented 4 months ago

This is now reelased: https://github.com/cryptoadvance/specter-desktop/releases/tag/v2.0.3