search

cryptoadvance / specter-desktop

A desktop GUI for Bitcoin Core optimised to work with hardware wallets
MIT License
789 stars 236 forks source link

Removing bleak entirely as it's only available for MacOS #2458

Open k9ert opened 2 weeks ago

k9ert commented 2 weeks ago

missing bleak caused: https://gitlab.com/cryptoadvance/specter-desktop/-/jobs/7112728484

I'm not sure why this did not came up earlier.

netlify[bot] commented 2 weeks ago

Deploy Preview for specter-desktop-docs canceled.

Name Link
Latest commit 9a7af5cb74969db34907860257db9d11a1c10d6e
Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/667ab8b0803ede00087d1976
k9ert commented 2 weeks ago

The tests have issues installing bleak:

 error: PyObjC requires macOS to build

It seems that this dependency is only available on MacOS. @moneymanolis can we remove that again? Do we want to support bluetooth for Jade anyway? I don't think it's a big loss, no?!

moneymanolis commented 1 week ago

haven't tested, though, whether the BLE class is somehow need by the rest of the Jade code. I don't think so.