search

cryptoadvance / specter-desktop

A desktop GUI for Bitcoin Core optimised to work with hardware wallets
MIT License
799 stars 238 forks source link

Inaccurate Instructions for Add Device for Cobo Vault #890

Open dtrammell opened 3 years ago

dtrammell commented 3 years ago

Looks like the in-app instructions for how to add a Cobo Vault device are inaccurate for Cobo's current app version. The in-app instructions state:

''' For single sig, click on: Setting -> Watch-Only Wallet -> Generic Wallet, click next then select the wallet address type you would like to use for your wallet. For multisig, click on: Multisig Wallet -> Show/Export XPUB, then select the wallet address type you would like to use for your wallet. Cobo Vault will then display the QR code which you should scan into Specter. To import with SD card, click on "touch here to export the file with microSD" on the same screen as the QR code. '''

In Cobo Vault's current app version 2.3.0, these instructions do not work. Specifically:

  1. "Watch-Only Wallet" menu item is in the root menu, not under "Settings"
  2. "Watch-Only Wallet" menu does not contain an item called "Generic Wallet" nor "Multisig Wallet"
  3. "Generic Wallet" nor "Multisig Wallet" menu items do not appear anywhere in the menu at all.
  4. The QR code screens (where available) do not provide an export to microSD option.

The instructions need to be updated to be current with the most recent Cobo Vault app version.

ben-kaufman commented 3 years ago

Hi, I've just checked with Cobo v2.3.1, everything still seems correct, and as it was previously. Are you sure you're using the Bitcoin-only edition of Cobo? We target Specter for Cobo's Bitcoin-only firmware.

mmikeww commented 3 years ago

confirmed same as ben, everything looks correct, 2.3.1 bitcoin-only firmware

ben-kaufman commented 3 years ago

Closing this for now then. Please reopen if you think this is indeed an issue.

dtrammell commented 3 years ago

Well, I updated the Cobo Vault to the Bitcoin-only firmware and retried adding it as a device. The instructions now match what I see in the device, however I ran into two issues:

  1. When attempting to scan the QR code, it would not scan. My computer's camera mirrors the video by default, so the wording and the QR code as seen by Specter was horizontally inverted. I think this caused Specter to not be able to scan the QR code. I would suggest adding a mirror/swap control on the scanner modal to allow users to easily fix this if Specter is seeing the QR code inverted.
  2. Because the QR code scan didn't work, I exported the XPUBs to a file and tried to upload the JSON file from the SD card. I selected the file and Specter seemed to accept it (no errors), but it did not populate the XPUBs in the interface. No idea what happened or why this didn't work as there were no errors; Specter just returned to the Add Device screen after the file selector went away.

Do you want to re-open this issue or create two new issues for each of these problems?

ben-kaufman commented 3 years ago

Hi, @dtrammell , which Specter version and which Cobo firmware version were you using?

dtrammell commented 3 years ago

Specter v1.0.0

Specterd Version: v1.0.0

Specterd File Hash: 910dca2d16df06983b8b8152125e4faf39f47282a497dadc88ac224b86105188

Cobo Vault Pro with Bitcoin-only Firmware: 0.4.2.000000 System Version CV_OS_V2.1.9 App Version 2.3.1(BTC-Only)

ben-kaufman commented 3 years ago

Can you try first updating to the latest versions (Specter 1.2.2, and Cobo 2.5.2) and retry, I believe import for the xpubs file should work fine...

dtrammell commented 3 years ago

Ok that worked a little better, and even scanned the QR code backwards. It only imported 1 XPUB though, for #0 Multisig Sig (Segwit). I tried switching the Cobo Vault QR to Nested Segwit and scanned again, but that QR code wouldn't scan at all. I exported them both to JSON files and the files imported ok though. Sorry for not having updated to most recent versions before trying, I didn't realize there was already a new version (I just installed a week or two ago). I guess y'all are cranking out new versions pretty quickly, I'll check for updates first in the future.

ben-kaufman commented 3 years ago

Ok so right now it works when importing files, but only sometimes with the camera right? I think that might just be an issue with camera quality, so you could try maybe more lighting or play with the distance from the camera

dtrammell commented 3 years ago

I actually did that, tried some different lighting, different distances, etc. I have a very nice camera, a Logitech StreamCam, so I don't think it's video quality. The camera will continually refocus every time I move the QR code closer or farther, and it focuses pretty well. It also scanned the first QR code for Native Segwit almost immediately.