search

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
440 stars 73 forks source link

BIP39 passphrase keyboard is missing some basic punctiation #128

Closed stevenroose closed 3 years ago

stevenroose commented 3 years ago

I was testing the DIY today (really cool device, I love the smartcard feature!) and noticed that the BIP39 passphrase prompt was missing come basic punctuation characters like a dash or a dot.

bitcoinheiro commented 3 years ago

Agree. Would be great to have all chars from the ASCII table. Noticed the following missing: 37 % 46 . 60 < 61 = 62 > 94 ^ 96 ` 123 { 124 | 125 } 126 ~

From Trezor documentation, for example: image

https://ascii.cl/

stepansnigirev commented 3 years ago

Good catch! Fixed in https://github.com/cryptoadvance/specter-diy/commit/04246ceb5ebedc889b97c73269e6191497d23acb Release with this fix is out already: https://github.com/cryptoadvance/specter-diy/releases/latest