search

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
440 stars 73 forks source link

UX upgrades to new key screen and easier display of recovery phrase #157

Closed moneymanolis closed 3 years ago

moneymanolis commented 3 years ago
  1. Generate new key
    • New word numbering, words from the BIP39 wordlist are now displayed from 1-2048 instead of 0-2047
    • "Next button" replaced by a "done button" to make clear that there is no other step.
grafik grafik
  1. Display of recovery phrase
    • Thus far, the display of the recovery phrase was a bit hidden, moved it one level higher to the settings screen.
grafik
openoms commented 3 years ago

just to check using a smartcard with firmware v1.5.4 the show recovery phrase does not work. The device asks for the PIN and returns for the menu without showing the seed.

Might not be touched by this PR, but a good place to test / reproduce.

stepansnigirev commented 3 years ago

just to check using a smartcard with firmware v1.5.4 the show recovery phrase does not work. The device asks for the PIN and returns for the menu without showing the seed.

Might not be touched by this PR, but a good place to test / reproduce.

That's strange, I just checked both in simulator and with the real device and smartcard - I can get the recovery phrase displayed.

Can you double-check?

openoms commented 3 years ago

Managed to reproduce the problem, but needs more detail. The recovery words are not shown if I switch the device on and proceed to load the keys from the smart card (it is stored encrypted there).

If I switch the device on and generate a keys the words can be shown. Then without switching off I can load the keys from the smartcard and in this case the (correct) words are shown again from the menu.

The problem is only when loading the keys from the smartcard without generating keys beforehand.