cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
441 stars 73 forks source link

Make multisig addresses bip67-compatible #21

Closed stepansnigirev closed 4 years ago

stepansnigirev commented 4 years ago

At the moment we are generating multisig addresses with pubkeys in the order of extended pub keys provided in the setup phase. This makes it compatible with current Bitcoin Core, but as sortedmulti descriptor is going to be added to Core we could change it to bip67 and sort pubkeys according to bip67.

stepansnigirev commented 4 years ago

Solved with https://github.com/cryptoadvance/specter-diy/commit/74f19a5de39bdf607322d7cc9caaa8a72ac3cf4c