search

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
440 stars 73 forks source link

fix processing of \r when importing binary seedqr #213

Closed stepansnigirev closed 1 year ago

stepansnigirev commented 1 year ago

Close #211 Until now we assumed that all messages from the host are text-based and end with \r - QR scanner is adding \r at the end of the data, so we were using it to split data coming from the scanner when multiple QR codes are scanned one after another.

This approach doesn't work when we start working with binary data. SeedQR integration is the first time we are handling QR codes in binary form.

This PR adds a possibility to tell the scanner that we are not expecting animated QR codes and ask for raw data coming from the scanner without pre-processing.

netlify[bot] commented 1 year ago

Deploy Preview for specter-diy-docs failed.

Name Link
Latest commit 634a6eab08949daa4ed42570856632bcad6410b8
Latest deploy log https://app.netlify.com/sites/specter-diy-docs/deploys/6300f15a413f8800089a0274