Make Export seed to SD consistent

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host

MIT License

447 stars 75 forks source link

Make Export seed to SD consistent #226

Closed stepansnigirev closed 1 year ago

stepansnigirev commented 1 year ago

There are two ways to export seed to SD card - via Flash & SD storage -> Export to SD card and via Show recovery phrase > SD. They save seed in two different formats, and that's wrong.

Suggestions:

Export to SD should save without bip39: prefix, or remove this menu from storage completely
Maybe add an option to use password-encrypted export (pbkdf2 of the password + random salt, then aes). Check existing standards to make sure we have metadata with encryption algorithm in the output

stepansnigirev commented 1 year ago

For now removed the old menu completely. https://github.com/cryptoadvance/specter-diy/commit/5b8ca01b090e012e653c316a7f16f88373611650