Sign with SD card creates invalid PSBT in some cases

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host

MIT License

446 stars 76 forks source link

Sign with SD card creates invalid PSBT in some cases #230

Closed stepansnigirev closed 1 year ago

stepansnigirev commented 1 year ago

From Telegram group:

I am trying to sign a psbt with specter desktop and specter diy. I can create the psbt with ‘desktop’ by selecting the device and ‘sign with SD card file’. I sign the psbt with ‘diy’ but when I choose ‘load signed transaction from file’ it says ‘Unknown error: Invalid PSBT magic’. I have checked the known bugs without finding this error.

Same when parsing tx in sparrow. Extra info: 3 of 5 multisig, CC signs correctly, DIY does something weird.

stepansnigirev commented 1 year ago

Tried to reproduce using 3-of-5 multisig, native segwit. With Specter-Desktop and Sparrow - didn't have any problems...

stepansnigirev commented 1 year ago

Fixed in https://github.com/diybitcoinhardware/f469-disco/commit/d8bc8a3fe57b01450db9aec59c92ff56f826b698