search

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
441 stars 73 forks source link

pin screen, antiphishing words and entropy encryption #26

Closed gorazdko closed 4 years ago

gorazdko commented 4 years ago

Status

ready for review

gorazdko commented 4 years ago

Thank you for your review, explanation and the learning material.

I will try to push the changes today or tomorrow.

gorazdko commented 4 years ago

I have force pushed the changes.

gorazdko commented 4 years ago

force pushed the latest changes

stepansnigirev commented 4 years ago

Awesome! Merging it! Now the only thing left is to implement the PIN counter with a reset after 10(?) wrong pins. If you are planning to implement it please keep in mind that it is very important to increase the PIN counter before checking the PIN:

  1. Increase the counter and save it,
  2. Check the PIN,
  3. PIN correct -> reset counter to 0 and save it
  4. PIN incorrect -> delete secret.json, reckless.json and all other user data.

We can store the PIN counter in the secret.json file for example.