search

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
440 stars 73 forks source link

PSBT_TAP_KEY_SIG not supported #277

Open pythcoiner opened 1 week ago

pythcoiner commented 1 week ago

Signing w/ the taproot internal key looks not implemented, cf here

signing w/ taptree works fine, can be tested on liana w/ this PR

stepansnigirev commented 1 week ago

When signing with internal key, embit finalizes the input right away. So instead of adding the signature to tap key signature field it creates final witness. But I agree, we should implement handling this field anyway

pythcoiner commented 1 week ago

will have a look!