search

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
441 stars 73 forks source link

implement factory settings #28

Closed gorazdko closed 4 years ago

gorazdko commented 4 years ago

Abstract

Device is reset to factory settings after 10 failed pin attempts; https://github.com/cryptoadvance/specter-diy/pull/26#issuecomment-568223353

stepansnigirev commented 4 years ago

Thank you! Sorry for a delay with the review - Christmas, the New Year, relatives...

One small question to discuss - should we delete wallet files or not when we do a factory reset?

What about the touchscreen calibration file? It's not there at the moment as I still didn't implement it, but would it make sense to keep it or better to remove everything and do a complete factory reset?

gorazdko commented 4 years ago

Wishing you all the best in 2020!

Yes, i will delete it recursively, and add a blacklist array to exempt folders/files. For now we can have an empty array. I will have to traverse the filesystem though since upython supports deleting individual file only, i think. But I will check tomorrow again.

gorazdko commented 4 years ago

force pushed changes

stepansnigirev commented 4 years ago

Great! Now we have a fully functional PIN code!