search

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
441 stars 73 forks source link

Code Review #3

Closed roshii closed 4 years ago

roshii commented 4 years ago

Some other easy fix

stepansnigirev commented 4 years ago

Awesome! Thanks!

stepansnigirev commented 4 years ago

FIY, I am currently rewriting the wallet to use libwally & libsecp256k1 and refactoring wallet architecture in general, so don't spend too much time on the core functionality yet...

roshii commented 4 years ago

Thanks for the heads up. So far I am simply getting familiar with MbedOS/STM32 platform and C/C++, learning to interact with internal storage and playing around with GUI. I did try for a couple hours to fix some issue I notice with root.fingerprint() but gotta catch-up on basics first! In short, I'm not ready to dive into core functions, yet :D

Real nice project btw, thanks!

stepansnigirev commented 4 years ago

Thanks! With root.fingerprint() I forgot to bump uBitcoin version, so just git pull to the latest version of the library - it has this functionality now.

roshii commented 4 years ago

just git pull to the latest version of the library - it has this functionality now.

Yeah !!! I have a home made hardware wallet :) I'll continue learning and try to contribute as soon as refactoring is published

Enjoy your weekend