qrscanner: scan qr animations automatically.

cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host

MIT License

441 stars 73 forks source link

qrscanner: scan qr animations automatically. #58

Closed gorazdko closed 4 years ago

gorazdko commented 4 years ago

Abstract

Close #56

After correcting some bugs, the scanning is now faster and more fluent.

Status

~ready for review~
does not support the expensive scanner
~wip: add pin trigger mode~
ready for review

stepansnigirev commented 4 years ago

Looks great! Let me test a bit more over the next few days and I will merge :)

We can drop support for an "expensive" scanner as nobody uses it anyway. Let's keep only minimal support for other scanners (no animations if qr scanner is in pin trigger mode). For these scanners there is always a possibility to scan non-animated QR code, and we should keep this as an option in specter-desktop - just because there are also other wallets that don't use animated QR codes.

I really like the feeling of scanning animated QR codes! Huge improvement in the UX.

gorazdko commented 4 years ago

I ~forced~ pushed changes. I tested pin triggered mode only with my scanner which is tricky. E.g. if you flash the code with pin triggered mode, it will not work as the baudrate in scanner is still 115200 and we're operating with 9600. If you get UnicodeError that means problem with baudrate.

But i dont know if this works with different scanners.

stepansnigirev commented 4 years ago

Great, it works like a charm! I was able to import a wallet with 10 cosigners and successfully signed a transaction with it. QR code scanning works very well.

Merging!