cryptoadvance / specter-diy

DIY airgapped hardware wallet that uses QR codes for communication with the host
MIT License
441 stars 73 forks source link

check for address gap limit violation #59

Closed gorazdko closed 4 years ago

gorazdko commented 4 years ago

Abstract

Close #50

Status

~WIP~ Ready for review:

stepansnigirev commented 4 years ago

Looks good! Gonna test tonight.

when browsing wallet addresses we currently allow to go back to address Nr. 1 regardless of max indexes . Should we disallow that or warn that these addresses may have been reused already?

I think we should warn that the address might be reused.

gorazdko commented 4 years ago

Fixed and force-pushed changes.

stepansnigirev commented 4 years ago

I tested, works great! Merging!