search

cryptobiu / MATRIX

MPC Simulation Framework
MIT License
24 stars 13 forks source link

Arrays and Boolean in JSON configuration files #22

Closed lenerd closed 5 years ago

lenerd commented 6 years ago

Hi,

is there any reason for using constructs like https://github.com/cryptobiu/MATRIX/blob/413642ae304324735fa4e3361a144f0232d7cf20/ProtocolsConfigurations/Config_SPDZ.json#L32-L37 or https://github.com/cryptobiu/MATRIX/blob/413642ae304324735fa4e3361a144f0232d7cf20/ProtocolsConfigurations/Config_GMW.json#L28-L29 in the configuration files?

We have arrays and Boolean values in JSON. Why not use them? e.g.

"regions": ["ap-south-1b", "eu-west-2b", "us-east-1b"],
"IsPublished": true, 
"isExternal": false,
lenerd commented 6 years ago

Also, options that somehow belong together (e.g., the Git or the AWS options) could be grouped together.