search

cryptobiu / MATRIX

MPC Simulation Framework
MIT License
24 stars 13 forks source link

fix missing upload of parties.conf #29

Closed lenerd closed 6 years ago

lenerd commented 6 years ago

This readds the lines lost in ef6ef8ad34ccce85cc581d86518d5ad0b7cd0a7f. See https://github.com/cryptobiu/MATRIX/pull/24#issuecomment-428650493.

I am not completely sure about the len(regions) > 1 case and have not tested that.

liorko87 commented 6 years ago

Fixed at #24

lenerd commented 6 years ago

Hi Lior,

Fixed at #24

I am not sure what you are referring to. The upload of the parties.conf is still missing in the external case without a coordinator:

https://github.com/cryptobiu/MATRIX/blob/776522cc1807b13fe2933f8613c50750603c117d/Execution/fabfile.py#L120-L124

I have updated the branch of this PR w.r.t. 9a7d5af7b15a172a91eda4ead2c1caca567cf7e2.

liorko87 commented 6 years ago

Hi Lennart,

I uploaded this line again, it's probably deleted by mistake.

Lior

lenerd commented 6 years ago

Hi, unfortunately, this is still broken for the multi-region case: Compare this (external with coordinator) https://github.com/cryptobiu/MATRIX/blob/e343af15e75d06d42e74d9335e18d166fd51db5f/Execution/fabfile.py#L112-L116 with this (external without coordinator) https://github.com/cryptobiu/MATRIX/blob/e343af15e75d06d42e74d9335e18d166fd51db5f/Execution/fabfile.py#L123-L124

liorko87 commented 6 years ago

Hi, When using the multi-region case, each server(instance) has it's own parties file (line 113). That's the reason why we added the party_id to each file. Afterwards at line 114 we are changing it to it's original name.

lenerd commented 6 years ago

Hi Lior,

I understand that. The problem is that these lines are missing for the case of an external protocol without a coordinator. In that case, every party gets the same configuration file whether multiple regions are used or not (line 123).