Why is working_directory a list?

cryptobiu / MATRIX

MPC Simulation Framework

MIT License

24 stars 13 forks source link

Why is working_directory a list? #45

Closed GuutBoy closed 5 years ago

GuutBoy commented 5 years ago

In the MATRIX config, why is the working_directory a list? It always seems to be of length 1, so why not just a string?

liorko87 commented 5 years ago

In most of the cases you are absolutely right. There are cases that we needed to run different protocols with the same configuration one after the other. Please take a look at the Comparison config file here.

This is the reason that these parameters are list and not strings:

workingDirectory
gitAddress
gitBranch
executableName

GuutBoy commented 5 years ago

I see. You might want to document that.

GuutBoy commented 5 years ago

This seems to be causing problems when running pre process tasks, because end_to_end.py is treating it as a string rather than list.

liorko87 commented 5 years ago

I'm working on full documentation of the system including detailed installation instructions and basic usage