search

cryptobiu / libscapi

Comprehensive Open Source Library for Secure Multiparty Computation
MIT License
180 stars 66 forks source link

Boost status in the build is a tad unclear #42

Closed srpgilles closed 6 years ago

srpgilles commented 6 years ago

In the installation guide for Linux, you mention Boost 1.60 must be installed.

However, during the build of libscapi an embedded Boost 1.64 is installed...

I therefore tried not to install the external Boost library (i.e. the 1.60 version); in this case all compiles well... until I try the sample compilation, which complains about the lack of Boost serialization. I checked, and indeed only a subset of Boost libraries is installed, with serialization omitted:

screen shot 2017-12-26 at 09 21 12

Wouldn't it be cleaner to omit the Boost 1.60 step and add serialization (and potentially other required Boost modules) in the libscapi build?

liorko87 commented 6 years ago

Hi @srpgilles Thank you for your comment, I will update the libscapi documentation. Your PR #43 will solve the problem.