cryptobiu / libscapi

Comprehensive Open Source Library for Secure Multiparty Computation
MIT License
180 stars 66 forks source link

Libscapi doesn't compile with gcc 6 or 7 #44

Closed srpgilles closed 6 years ago

srpgilles commented 6 years ago

I tried compiling the code with gcc 6 or 7 (in a Ubuntu container), and I got a compilation issue with libOTe:

screen shot 2017-12-26 at 13 06 22
liorko87 commented 6 years ago

Hi, Please check after git pull. Change is at commit cdea784.

We checked it on our machine with GCC 6.3

srpgilles commented 6 years ago

Hi,

sorry for the delay: I’m just coming back from vacation, where the connexion was way too poor to play with my Dockerfile…

I’ve just checked the proposed change with gcc 6 and 7 and both are compiling smoothly the code.

Thanks for your quick reply,

Best regards,

Sébastien

On 28 Dec 2017, at 08:17, liorbiu notifications@github.com wrote:

Hi, Please check after git pull. Change is at commit cdea784 https://github.com/cryptobiu/libscapi/commit/cdea784d7b0380f1b38b043ae61409a10479efce.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cryptobiu/libscapi/issues/44#issuecomment-354241868, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlFS37ZKCiKjJAY4IgmSStD_CQ7h379ks5tE0BtgaJpZM4RMu51.

srpgilles commented 6 years ago

Hi,

I’m really sorry but I realized I messed up with my Dockerfile and it was still actually gcc 5 that was used.

Both gcc 6 and 7 still actually fail due to the same error in cryptoTools:

In file included from /home/libscapi/build/libOTe/cryptoTools/cryptoTools/../cryptoTools/Crypto/PRNG.h:4:0, from /home/libscapi/build/libOTe/cryptoTools/cryptoTools/../cryptoTools/Common/BitVector.h:5, from /home/libscapi/build/libOTe/libOTe/NChooseOne/Kkrt/KkrtNcoOtSender.h:4, from /home/libscapi/build/libOTe/libOTe/NChooseOne/Kkrt/KkrtNcoOtSender.cpp:1: /home/libscapi/build/libOTe/cryptoTools/cryptoTools/../cryptoTools/Crypto/AES.h: In instantiation of 'void osuCrypto::MultiKeyAES::ecbEncNBlocks(const block, osuCrypto::block) const [with int N = 4; osuCrypto::block = __vector(2) long long int]': /home/libscapi/build/libOTe/libOTe/NChooseOne/Kkrt/KkrtNcoOtSender.cpp:183:62: required from here /home/libscapi/build/libOTe/cryptoTools/cryptoTools/../cryptoTools/Crypto/AES.h:102:77: error: '_mm_aesenc_si128' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive] for (int i = 0; i < N; ++i) cyphertext[i] = _mm_aesenc_si128(cyphertext[i], mAESs[i].mRoundKey[1]);


compilation terminated due to -Wfatal-errors.

I tried using your dev branch to see if this was solved since but you must have something icky on it: there is a internal compiler error related to Boost on this branch.

Best regards,

Sébastien

PS: Please find joined the Dockerfile I used to find this error.

> On 8 Jan 2018, at 11:34, S�bastien Gilles <srpgilles@gmail.com> wrote:
> 
> Hi,
> 
> sorry for the delay: I’m just coming back from vacation, where the connexion was way too poor to play with my Dockerfile…
> 
> I’ve just checked the proposed change with gcc 6 and 7 and both are compiling smoothly the code.
> 
> Thanks for your quick reply,
> 
> Best regards,
> 
> Sébastien
> 
> 
> 
> 
>> On 28 Dec 2017, at 08:17, liorbiu <notifications@github.com <mailto:notifications@github.com>> wrote:
>> 
>> Hi,
>> Please check after git pull. Change is at commit cdea784 <https://github.com/cryptobiu/libscapi/commit/cdea784d7b0380f1b38b043ae61409a10479efce>.
>> 
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub <https://github.com/cryptobiu/libscapi/issues/44#issuecomment-354241868>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABlFS37ZKCiKjJAY4IgmSStD_CQ7h379ks5tE0BtgaJpZM4RMu51>.
>> 
> 
liorko87 commented 6 years ago

Hello,

Can you please attach your docker file or attach the error message related to Boost?

Lior

srpgilles commented 6 years ago

Hello,

here is the Dockerfile which yield the cryptoTools error.

The Boost error is the dev branch is chosen rather than the master one (I also put the Dockerfile below).

Best regards,

Sébastien

On 14 Jan 2018, at 07:26, liorbiu notifications@github.com wrote:

Hello,

Can you please attach your docker file or attach the error message related to Boost?

Lior

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cryptobiu/libscapi/issues/44#issuecomment-357491634, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlFS03tDVY2zrQ0TOm1hFYQwdJcVBNwks5tKZ4xgaJpZM4RMu51.

liorko87 commented 6 years ago

Hello,

I can't see your docker file.

Lior

srpgilles commented 6 years ago

Hello,

ok I don’t understand why you do not see them (they appear in my mailer so I didn’t forget them); here is a link to download them:

https://filesender.renater.fr/?s=download&token=b933e8ef-593f-396f-b8b2-3daa0470ff83 https://filesender.renater.fr/?s=download&token=b933e8ef-593f-396f-b8b2-3daa0470ff83

Best regards,

Sébastien

On 15 Jan 2018, at 11:40, liorbiu notifications@github.com wrote:

Hello,

I can't see your docker file.

Lior

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cryptobiu/libscapi/issues/44#issuecomment-357645731, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlFS94AU82LtZA0hSqPz6EFMjLwsdsEks5tKys4gaJpZM4RMu51.

liorko87 commented 6 years ago

Hi, Please use the latest commit on dev branch, I fixed a bug in one of our sources files. I checked your docker files and it compiles successfully.

Later we will transform the change to master

srpgilles commented 6 years ago

Hi,

I confirm my Docker file with gcc 7 is compiling correctly.

Thanks!

Best regards,

Sébastien

On 21 Jan 2018, at 13:04, liorbiu notifications@github.com wrote:

Hi, Please use the latest commit on dev branch, I fixed a bug in one of our sources files. I checked your docker files and it compiles successfully.

Later we will transform the change to master

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cryptobiu/libscapi/issues/44#issuecomment-359243362, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlFS8OUL4YHwtqPkMTc0RjTj7Y0MFScks5tMyfWgaJpZM4RMu51.