Add confirm dialog on delete?

cryptoboid / splitio

split your bills easily! splitio is an open-source webapp built for tracking debts and payments quickly, without any user accounts. works as a splitwise-clone

https://splitio.vercel.app/

GNU Affero General Public License v3.0

87 stars 13 forks source link

Add confirm dialog on delete? #2

Closed chmac closed 2 years ago

chmac commented 2 years ago

I think it would make sense to add a "are you sure" check, even with a simple globalThis.prompt() on deleting expenses. It's a bit too easy to double click for example and delete an expense which I guess there's no way to recover. At least I don't see any obvious undo / redo type functionality.

cryptoboid commented 2 years ago

Agreed! It is something I've considered for sure, will add it soon!

chmac commented 2 years ago

I'm happy to submit a PR if you like, using a confirm it should be easy.

cryptoboid commented 2 years ago

Added with last commit. Wanted to give it a materialUI dialog for consistency :)

chmac commented 2 years ago

Awesome! Big improvement for the feeling of safety using the app, thanks for the quick turnaround.