search

cryptocoinjs / base-x

Encode/decode any base
MIT License
312 stars 75 forks source link

Support TypeScript #58

Closed junderw closed 5 years ago

junderw commented 5 years ago
  1. Commit JS source for verifiability.
  2. Target ES5 closes #51

Javascript transpilers will some day insert private key stealing virus into some React Native app and people will wonder what happened......

But for now, as long as we commit and track the JS changes, we can verify that nothing is wrong on OUR end.

Now types are supported too, hooray.

junderw commented 5 years ago

I found that copy pasting the old index.js and the new transpiled index.js into a diff checking GUI app like meld was helpful... it highlighted the changes which is mostly just const and let removal.

junderw commented 5 years ago

will tag this with v3.0.6 and publish once I can get an ACK from someone.

junderw commented 5 years ago

Published as v3.0.6