cryptocoinjs / bs58

Base58 encoding/decoding for Bitcoin
http://cryptocoinjs.com/modules/misc/bs58/
MIT License
216 stars 48 forks source link

rm lib/, use index.js #14

Closed dcousens closed 9 years ago

dcousens commented 9 years ago

Any reason to use lib/? I've only ever seen it in transpiled libraries, so seeing it here confused me a little bit. Even more confusing is its presence in such a simple module.

Not really an issue though, so feel free to reject if you feel this isn't necessary.

jprichardson commented 9 years ago

Any reason to use lib/? I've only ever seen it in transpiled libraries, so seeing it here confused me a little bit.

I'd be willing to bet that at least 50% of the top 50 npm libraries use lib for a directory. Regardless, switching to index.js is fine.

dcousens commented 9 years ago

:+1: I guess I need to diversify, I haven't seen an instance of that in several months.

jprichardson commented 9 years ago

I've actually been thinking a bit about this since I've been transpiling with babel... for S&G's...

From what I checked:

Use lib:

Didn't use lib:

When I wrote CoffeeScript, I use to transpile from src/ to lib/.... but when I started JavaScript, I started just using lib/. Lately, I prefer just putting everything in index.js or as much as possible...

jprichardson commented 9 years ago

\ cough **

I guess I need to diversify, I haven't seen an instance of that in several months.

@dcousens Aren't you a collaborator on both of these projects?

dcousens commented 9 years ago

Haha. I guess in that sense bn.js is already ready "transpiled" for the browser. 1 file and all that. As for elliptic, ha. Woops.