search

cryptocoinjs / coininfo

JavaScript component for crypto currency specific information.
116 stars 114 forks source link

bip44-constants #19

Closed fanatid closed 3 years ago

fanatid commented 8 years ago

Resolve #18

jprichardson commented 8 years ago

Thanks. Do you think that it makes sense to just remove the bip44 constants altogether? i.e. Just encourage people to use bip44-constants?

fanatid commented 8 years ago

Do you think that it makes sense to just remove the bip44 constants altogether? i.e. Just encourage people to use bip44-constants?

Not sure. I think use all information about coin from one place it's nice.

fanatid commented 8 years ago

@jprichardson you don't forget about this PR? probably this PR need major bump, because I change some coin names for consistent with bip44-constants

jprichardson commented 8 years ago

Do we want to return the number with the ' or without? e.g. for Dogecoin, should we be returning:

bip44Constants.Dogecoin - 0x80000000 or bip44Constants.Dogecoin

??

fanatid commented 8 years ago

Why you want this? SLIP-0044 has numbers with '

jprichardson commented 8 years ago

Why you want this? SLIP-0044 has numbers with '

Exactly. Since when you pass the constant to a derive() function, you typically need the ' (bip44Constants.Dogecoin) instead of (bip44Constants.Dogecoin + 0x80000000).

But since all have 0x80000000, it could make it hard to detect differences. IDK, I'm probably splitting hairs here.

fanatid commented 8 years ago

maybe return two constants? one with ' and one without '?

jprichardson commented 8 years ago

Hmmm, still thinking about this.