Remove cionstring dependency

cryptocoinjs / hdkey

JavaScript component for Bitcoin hierarchical deterministic keys (BIP32)

MIT License

201 stars 74 forks source link

Remove cionstring dependency #25

Closed LogvinovLeon closed 4 years ago

LogvinovLeon commented 5 years ago

Coinstring is deprecated. https://github.com/cryptocoinjs/coinstring It also doesn't have a licence and by default this code in contributed to it's author, not open source.

RyanZim commented 5 years ago

I see no reason not to welcome a PR changing this.

BTW, I know the author of coinstring personally, and I'm positive the license omission was simply an oversight.

LogvinovLeon commented 5 years ago

It's a low priority for me. Just wanted to let you know. If it's an oversight - I'm OK with that. Feel free to close the issue

RyanZim commented 4 years ago

Fixed in https://github.com/cryptocoinjs/hdkey/pull/30.