search

cryptocoinjs / hdkey

JavaScript component for Bitcoin hierarchical deterministic keys (BIP32)
MIT License
201 stars 74 forks source link

use ripemd160 instead of rmd160 for electron 4.0 uses BoringSSL #26

Closed twksos closed 5 years ago

twksos commented 5 years ago

We are working on an Electron 4.0 project. Electron 4.0 uses BoringSSL and removed the alias(rmd160 -> ripemd160). We replaced rmd160 with ripemd160 which works in both OpenSSL and BoringSSL.

jprichardson commented 5 years ago

Thanks. Have old Node.js versions always supported both aliases? I'm asking to be sure we maintain semver.

twksos commented 5 years ago

@jprichardson From the test result, it works on node 6, 8, 10.

twksos commented 5 years ago

Hi @jprichardson , I've double checked the OpenSSL code, the aliases should exists in OpenSSL v0.9.6 around year 2003. And at least from node 0.7.4 it directly uses function from OpenSSL.

We should be fine with this change.