Closed homura closed 4 years ago
utACK it looks good to me.
Bonus: found #33 when verifying this code change.
Any chance this gets merged and released soon?
Hi, just wanted to give this a cautious iteration: we have an outstanding release - see https://github.com/ethereumjs/ethereumjs-wallet/issues/113 - and a merge and subsequent release here would substantially improve the installation experience since one main part was to update the secp256k1
dependencies to v4.0
coming with the pre-build binaries.
If not possible so be it but otherwise a release here would be super cool! 😄
@holgerd77 thanks. I had no idea this was used in ethereumjs-wallet
. Will have this merged and updated.
@jprichardson Thanks, that's so great! 😄
Published in v2.0.0 :tada:
Thanks for the release, great! 😄
We have some tests failing now with the updated version. Didn't get a chance to have a look yet, but just to already raise some awareness here.
Since secp256k1 v4.0 use the N-API, this can avoid some unexpected situations similar to when worker_thread calls binding and use Pure JS version
Try the following code, and run with
secp256k1@3.8
andsecp256k1@4.0
, you will find that in the worker_thread, the error caused byModule did not self-register
will cause its performance to decrease due to the implementation of the JS version